Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated dashboard for new Recorded Future integration #30199

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Updated dashboard for new Recorded Future integration #30199

merged 1 commit into from
Feb 4, 2022

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Feb 3, 2022

What does this PR do?

Updates the existing Recorded Future dashboard in the Threat Intel module.

Why is it important?

After the integration was rewritten, the dashboard needs adjustment because some fields have changed.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Relates #30030

Screenshots

image

@adriansr @peasead
Dashboard for new Recorded Future integration
806e8df 
Relates elastic#30030

Co-authored-by: Andrew Pease <7442091+peasead@users.noreply.github.com>
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 3, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2022

This pull request does not have a backport label. Could you fix it @adriansr? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Feb 3, 2022
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-02-03T22:21:23.482+0000

  • Duration: 105 min 2 sec

  • Commit: 806e8df

Test stats 🧪

Test Results
Failed 0
Passed 2429
Skipped 154
Total 2583

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@adriansr adriansr requested a review from P1llus February 4, 2022 09:09
@adriansr adriansr merged commit b8203a3 into elastic:main Feb 4, 2022
@adriansr adriansr deleted the new_rf_dashboard branch February 4, 2022 09:10
@adriansr adriansr added backport-v8.1.0 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Feb 10, 2022
mergify bot pushed a commit that referenced this pull request Feb 10, 2022
@adriansr
Dashboard for new Recorded Future integration (#30199)
4100c56 
Relates #30030

Co-authored-by: Andrew Pease <7442091+peasead@users.noreply.github.com>
(cherry picked from commit b8203a3)
@mergify mergify bot mentioned this pull request Feb 10, 2022
Merged
adriansr added a commit that referenced this pull request Feb 10, 2022
@mergify @adriansr
Dashboard for new Recorded Future integration (#30199) (#30330)
b9fc658 
Relates #30030

Co-authored-by: Andrew Pease <7442091+peasead@users.noreply.github.com>
(cherry picked from commit b8203a3)

Co-authored-by: Adrian Serrano <adrisr83@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

@P1llus P1llus Awaiting requested review from P1llus

Assignees
No one assigned
Labels
backport-v8.1.0 Automated backport with mergify :Dashboards enhancement Filebeat Filebeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adriansr @elasticmachine @efd6